[RNMobile] Allow wildcard block transformations for container blocks #48792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluiddot
added
[Type] Bug
fluiddot
commented
Mar 6, 2023
| * | ||
| * @param {import('@testing-library/react-native').RenderAPI} screen The Testing Library screen. | ||
| */ | ||
| export const openBlockActionsMenu = async ( screen ) => { |
There was a problem hiding this comment.
I introduced this test helper to simplify the action of opening the Block actions menu, which is needed for transforming a block.
Comment on lines
+20
to
+29
| // NOTE: Paragraph block can be transformed to Buttons block in web, | ||
| // however this transform is not supported in the native version. | ||
| const transformsWithInnerBlocks = [ 'List', 'Quote', 'Columns', 'Group' ]; | ||
| const blockTransforms = [ | ||
| 'Heading', | ||
| 'Preformatted', | ||
| 'Pullquote', | ||
| 'Verse', | ||
| ...transformsWithInnerBlocks, | ||
| ]; |
There was a problem hiding this comment.
This unit test covers the blocks that a Paragraph block can be transformed to:
- Heading ✅
- List ✅
- Quote ✅
- Buttons (only in web) ❌ => Native version needs
document.createHTMLDocumentfunction to work. - Preformatted ✅
- Columns ✅
- Verse ✅
- Pullquote ✅
- Group ✅
|
Size Change: -10 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
derekblank
approved these changes
Mar 7, 2023
This was referenced Mar 7, 2023
|
As mentioned in the PR's description:
I'm going to reference the follow-up PRs that include the unit tests. Since we incorporated new transformations, I'd like also to take the opportunity on those PRs to perform manual tests as a double-check:
@derekblank since you reviewed this PR, I'm wondering if you could also take a look at some of the rest. Thanks 🙇 ! |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Allow wildcard block transformations for container blocks in the native version of the editor.
Why?
Fix #44452.
One of the Paragraph blocks' transformations is to the Quote block. The v2 of the Quote block, which was released some time ago, allows inner blocks which makes it a container block. This change made the native version of the editor remove the Quote block transformation option based on the following code:
gutenberg/packages/blocks/src/api/factory.js
Lines 214 to 220 in d1ab8ce
How?
Disable the restriction that disallows wildcard block transformations for container blocks. It's not clear why we introduced this restriction when native block transformations were added, however, per the tests I've made seems the issues we might have by that time can no longer be reproduced.
This change will also allow new transformations for most of the blocks we support in the native version. In the following list, I outline the new transformations:
NOTE: As mentioned above, this PR will allow new transformations so I'll create another PR adding unit tests to cover the different transformations of all blocks.
UPDATE: Here are the follow-up PRs:
Testing Instructions
Testing Instructions for Keyboard
N/A
Screenshots or screencast
N/A