Lodash: Refactor away from edit-post package
#48786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Performance
tyxla
requested review from
Mamaduka,
sgomes,
aristath,
jsnajdr,
swissspidy,
flootr,
jorgefilipecosta,
chad1008,
ntsekouras,
fabiankaegy and
brookewp
ntsekouras
reviewed
Mar 6, 2023
|
Size Change: -5 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
tyxla
force-pushed
the
refactor/lodash-edit-post-package
branch
from
2c5b5ea to
b73fce6
Compare
tyxla
force-pushed
the
refactor/lodash-edit-post-package
branch
from
b73fce6 to
d15ac33
Compare
tyxla
commented
Mar 6, 2023
| 'labels', | ||
| 'menu_name', | ||
| ] ) } | ||
| label={ taxonomy.labels.menu_name } |
There was a problem hiding this comment.
We're already using taxonomy as a non-nullish object here, and a valid taxonomy entity record will always have a labels object.
|
Flaky tests detected in d15ac33. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4345359173
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes the remaining Lodash from the
@wordpress/edit-postpackage.Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetchpackage haslodashas a dependency #39495How?
Usages are straightforward. We're using direct access instead of
_.get(), coupled with optional chaining where necessary. We're usingObject.fromEntries( Object.entries().map() )instead of_.mapValues()andArray.prototype.lengthinstead ofisEmpty()sincefillsin theSlotcallback are always provided as an array.Testing Instructions