Lodash: Refactor away from _.kebabCase() in EditorHelpTopics
#48776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Performance
tyxla
requested review from
Mamaduka,
sgomes,
dcalhoun,
aristath,
jsnajdr,
swissspidy,
geriux,
AmandaRiu,
flootr,
chad1008,
fluiddot,
ntsekouras,
fabiankaegy and
brookewp
|
Size Change: +375 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
sgomes
approved these changes
Mar 6, 2023
| @@ -1,7 +1,7 @@ | |||
| /** | |||
| * External dependencies | |||
| */ | |||
| import { kebabCase } from 'lodash'; | |||
| import { paramCase as kebabCase } from 'change-case'; | |||
There was a problem hiding this comment.
Can any of these uses (labels, as far as I can tell) be non-ASCII? I remember this caused issues before.
There was a problem hiding this comment.
|
Flaky tests detected in fc78d13. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4343542072
|
sgomes
approved these changes
Mar 6, 2023
There was a problem hiding this comment.
Sounds good, thank you @tyxla!
Minor nit; feel free to ignore: perhaps we could simplify things by doing:
import { paramCase } from 'change-case';
const kebabCaseSettings = [...];
function kebabCase( str ) {
return paramCase( str, kebabCaseSettings );
}?
dcalhoun
reviewed
Mar 6, 2023
|
Thanks a bunch for the confirmation @dcalhoun 🙌 |
fluiddot
reviewed
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes Lodash's
_.kebabCase()from theEditorHelpTopicscomponent.Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetchpackage haslodashas a dependency #39495How?
We're using
paramCasefrom thechange-casepackage, which we've been using as an all-around replacement.This is a straightforward change since it works with predictable values (values that are already declared as localized sentence strings above in the same file).
Testing Instructions