Packages: Remove completely two deprecated webpack plugins #48770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
requested review from
ntwb,
nerrad,
ajitbohra,
ryanwelcher,
juanmaguitar and
fabiankaegy
as code owners
|
Size Change: 0 B Total Size: 1.34 MB ℹ️ View Unchanged
|
youknowriad
approved these changes
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
@wordpress/library-export-default-webpack-pluginis marked as deprecated since 2021-08-23:With 2d04345 we have now also
@wordpress/custom-templated-path-webpack-pluginmarked as deprecated:Why?
Both packages are unnecessary since we migrated the Gutenberg plugin and WordPress core to webpack 5. They are no longer referenced in both repositories for nearly a year. The last time those packages were in use was 11 months ago when we migrated WordPress core to webpack 5: https://core.trac.wordpress.org/ticket/51750.
How?
Let's remove both packages completely from the repository and mark them as deprecated on npm using the admin interface.
In fact, I marked both packages as deprecated on npm but as soon as the new version got published, then npm removed the big red banner.
The source code for packages will still lives in
wp/X.Ybranches, so we will be able to patch them if that ever becomes necessary. However, I doubt it will.