Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Playwright Utils: Fix the 'publishPost' address locator #48729

Merged
merged 2 commits into from
Mar 3, 2023
Merged

Playwright Utils: Fix the 'publishPost' address locator #48729

merged 2 commits into from
Mar 3, 2023

Conversation

Mamaduka
Copy link
Member

@Mamaduka Mamaduka commented Mar 3, 2023

What?

PR fixes the locator for published post URL addresses.

Why?

The input label changes based on the post type name, so if you publish a Page or CPT, the field label would be - "{CPTName} Address".

How?

I've updated the locator to use RegExp.

Testing Instructions

CI tests are passing.

@Mamaduka Mamaduka requested a review from kevin940726 as a code owner March 3, 2023 14:03
@Mamaduka Mamaduka self-assigned this Mar 3, 2023
@Mamaduka Mamaduka added [Type] Bug An existing feature does not function as intended [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. labels Mar 3, 2023
@Mamaduka Mamaduka requested a review from DAreRodz March 3, 2023 14:03
kevin940726
kevin940726 approved these changes Mar 3, 2023
View reviewed changes
Copy link
Member

@kevin940726 kevin940726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

packages/e2e-test-utils-playwright/src/editor/publish-post.ts Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Mar 3, 2023 •
edited
Loading

Flaky tests detected in 39f93ac.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4324320499
📝 Reported issues:

@Mamaduka Mamaduka merged commit 0420e49 into trunk Mar 3, 2023
@Mamaduka Mamaduka deleted the fix/playwright-utils-publish-post branch March 3, 2023 15:50
@github-actions github-actions bot added this to the Gutenberg 15.4 milestone Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin940726 kevin940726 kevin940726 approved these changes

@DAreRodz DAreRodz Awaiting requested review from DAreRodz

Assignees

@Mamaduka Mamaduka

Labels
[Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 15.4
Development

Successfully merging this pull request may close these issues.
2 participants
@Mamaduka @kevin940726