withFallbackStyles: Convert to TypeScript #48720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
commented
Mar 3, 2023
Comment on lines
+32
to
+33
| constructor( props: Props ) { | ||
| super( props ); |
There was a problem hiding this comment.
This change addresses the prefer-rest-params lint error. Runtime behavior should be the same.
|
Size Change: +3 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 3efa8b1. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4322535805
|
ciampo
approved these changes
Mar 3, 2023
There was a problem hiding this comment.
LGTM 🚀
Optional improvement: (feel free to ignore or to just apply partially, given the very low usage of this HOC)
It would be good to somewhat indicate that the type of the return value of mapNodeToProps is the same as the fallbackStyles state, and that the type of Props['node'] is the same type of the node argument in mapNodeToProps.
I took a look at definitely typed defs, maybe we could borrow inspiration from those?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #35744
What?
Convert the
withFallbackStylesHOC to TypeScript.Why?
It isn't really necessary that these HOCs are typed at this point, but just converting them because they are pretty simple. We can
ts-nocheckany of the ones that are not worthwhile.Testing Instructions
✅ Static checks pass.