LinkControl: Remove HTML from suggestion title before passing it to TextHighlight component #48685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ht component add inline comment
fabiankaegy
added
[Type] Bug
|
Size Change: +1 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
Mamaduka
changed the title
Mamaduka
approved these changes
Mar 2, 2023
packages/block-editor/src/components/link-control/search-item.js
Outdated
Show resolved
Hide resolved
|
Flaky tests detected in 0addf48. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4314601232
|
Co-authored-by: George Mamadashvili <[email protected]>
getdave
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
strip html tags from suggestion.title before passing it to
TextHighlightcomponentWhy?
An alternate approach to #48674 to close #48672
How?
wrapping the
suggestion.titlein astripHTMLfunction callTesting Instructions
markelement with any tag in it. For example:<mark style="">test</mark> pageBefore this patch this caused the block to error.
Testing Instructions for Keyboard
Not applicable