Prefer committer over author date for perf results timestamp #48673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WunderBart
added
[Type] Performance
In Git, the author date is when someone first creates a commit with git commit. The commit date is identical to the author date unless someone changes the commit date by using git commit --amend, a force push, a rebase, or other Git commands.
WunderBart
force-pushed
the
fix/perf-results-committed-at
branch
from
3d64a71 to
3fa52ea
Compare
dmsnell
approved these changes
Mar 2, 2023
There was a problem hiding this comment.
I'm not sure how to test this apart from merging and watching, so if you will do that then it seems good.
It's good to get rid of the extra step in the job. Also I'm guessing we have out-of-order commits in codehealth because of having been reporting the author date. I doubt that's significant for the purpose of tracking these things over time, but I feel like I've seen some commits where the author date was weeks behind the commit.
|
The ordering by date should be fixed by Perf logging: change date to ISO 8601. |
|
@ellatrix what are you referring to? did you mean to link to this same PR in your comment? |
|
Huh, no idea why that linked to the this PR. I meant: #51833 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Related: #48243 (comment)
Prefer the commiter date over the author date for logging performance tests results.
Why?
There's a mismatch between
COMMITTED_ATandcommit_details.data.author.datawhereby the author can choose a time for the commit, but the actual time of the commit is different. From the docs:How?
Get the committer timestamp directly via git instead of fetching via the script action as suggested by @dmsnell here.