-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Style Book: Move iframe to root of content area to support styles that overflow block previews #48664
Merged
ntsekouras
merged 12 commits into
trunk
from
update/style-book-to-use-iframe-at-root-of-style-book-content
Mar 8, 2023
Merged
Style Book: Move iframe to root of content area to support styles that overflow block previews #48664
Changes from 6 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
8d81fa8
Style Book: Try moving iframe to root of content area
andrewserong 5e5b7c3
Try to match styles inside the iframe to the existing text styles fro…
andrewserong bb07045
Restore margin rules to prevent vertical margins on previews from aff…
andrewserong 8f37070
Fix svg filters, attempt to fix tabbing behaviour
andrewserong fb5e755
Add Enter key handling, button role, update e2e tests
andrewserong 70696cb
Tidy hard-coded styling rules
andrewserong 4dd2009
Switch back to button element, add additional focus styles, update e2…
andrewserong 0079f98
Remove unneeded CSS rules
andrewserong 239b700
Update e2e test
andrewserong 4fd840f
Improve caching of blocks
andrewserong cf0aec6
Try swapping out button element for Composite and CompositeItem
andrewserong f1a2c35
Update id key, remove unnecessary memo call
andrewserong File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't need to set background and border to
none
, or color toinherit
here because we've already unset everything above.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, good catch, I'll tighten these up 👍