Post Editor: Apply busy status to the publish button in progress and unify button width #48444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +5 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in ff9fb65. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4270084069
|
jasmussen
approved these changes
Feb 27, 2023
There was a problem hiding this comment.
Before:
After:
This is a really nice improvement, thank you.
One little issue you will note in both of the above GIFs is that the disabled active state makes the button slightly wider, for some reason. As noted, this appears to be an existing issue, so fine to ignore. But if you can find out what makes it grow larger in its active state, and fix it so the width doesn't change, that would be bonus points! 🙏
t-hamano
force-pushed
the
enhancement/post-editor-busy-state
branch
from
ff9fb65
to
56ccff3
Compare
t-hamano
force-pushed
the
enhancement/post-editor-busy-state
branch
from
56ccff3
to
c035759
Compare
|
Thanks for the review, @jasmussen!
This makes sense. This is due to the fact that the width of the buttons are not fixed, for example, the difference will be more pronounced if the length of the text on each button differs from language to language:
However, since the buttons are of equal width in the site editor, the same should be true for the submission editor:
I updated my PR and now it works like this in the post editor:
|
t-hamano
changed the title
|
Beautiful 👏 |
37 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR applies a busy status to the Publish button when the publication process is in progress.
Why?
If the button text is in progress, I think it should indicate busy status.
Screenshots or screencast
Before
After
When the status is as follows, the status of the button remains the same as before.
Updating draft post
Swithing to draft post
Updating published post