Remove unused CSS from LinkControl Apply button #48431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
[Type] Code Quality
|
Size Change: +1.08 kB (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in a9be052. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4265319783
|
jeryj
reviewed
Mar 1, 2023
There was a problem hiding this comment.
I searched the codebase and couldn't find any situation in the JS where the CSS .block-editor-link-control__search-submit was used. I also searched for any instances of xblock-editor-link-control__search-submit and couldn't find anything in the codebase. This seems safe.
I did find a reference to block-editor-link-control__search-submit in the LinkControl README.md. Is it worth removing it from there too?
|
Alternatively I guess we could reinstate the class but just ensure no CSS is applied. That way any 3rd party targetting that class still gets the styles. |
getdave
commented
Mar 2, 2023
getdave
changed the title
|
@jeryj Thanks for review. I made a change. Now seeking a 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Removes an unused, legacy
classnameCSS code from the submit/apply buton in Link Control.Why?
Because it's not in use.
How?
Remove
class andany CSS references.Testing Instructions
Check Link Control appears as per
trunk.Testing Instructions for Keyboard
Screenshots or screencast