Fix perf regression in duotone hooks #48401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
reviewed
Feb 24, 2023
getdave
requested review from
scruffian,
MaggieCabrera,
jeryj,
ajlende and
draganescu
getdave
added
[Type] Performance
youknowriad
reviewed
Feb 24, 2023
|
Size Change: +156 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 2a2efa1. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4262120770
|
youknowriad
reviewed
Feb 24, 2023
youknowriad
approved these changes
Feb 24, 2023
|
Thanks for the follow-up. |
getdave
commented
Feb 24, 2023
Comment on lines
+272
to
+274
| const duotoneSupportSelectors = getBlockSupport( | ||
| name, | ||
| 'color.__experimentalDuotone' |
There was a problem hiding this comment.
I found this line confusing because it seems related to block supports but in actual fact it's just retrieving the CSS selectors defined as targets for the duotone. It will be better once we move this support to a dedicated filters.duotone key.
getdave
commented
Feb 24, 2023
Comment on lines
+280
to
+283
| const selectorsGroup = scopeSelector( | ||
| `.editor-styles-wrapper .${ id }`, | ||
| duotoneSupportSelectors | ||
| ); |
There was a problem hiding this comment.
I know @ajlende has a follow up which uses standard Theme JSON class methods to handle this.
This was a close one!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes a performance regression likely introduced by #48318.
See #48318.
Why?
The refactor in #48318 caused some hooks to be executed for all blocks and not just those which support duotone. This has a big impact on performance, especially as some of those hooks were doing potentially expensive lookups in settings.
How?
Established a component guard pattern where by:
editor.BlockEditeditor.BlockListBlockearlyJSX conditionals to help encourage developers to consider the perf impact of future changes. Ideally this wouldn't be necessary but given that the code is not well covered with tests (and developers are human) it's probably our best bet of avoiding this happening again.returnsTesting Instructions
The goal is that Duotone support in the Editor on blocks behaves exactly as per
trunk(but just with better performance).Manual testing should involve:
"templateLock": "contentOnly").Testing Instructions for Keyboard
Screenshots or screencast