Upgrade typescript to 4.9.5
#48299
Merged
Upgrade typescript to 4.9.5
#48299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
added
the
[Type] Code Quality
|
Size Change: +410 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
kevin940726
commented
Feb 22, 2023
| @@ -151,7 +151,7 @@ export { isAppleOS }; | |||
| /** | |||
| * Map the values of an object with a specified callback and return the result object. | |||
| * | |||
| * @template T | |||
| * @template {{ [s: string]: any; } | ArrayLike<any>} T | |||
There was a problem hiding this comment.
| @@ -87,7 +87,7 @@ function isValidFocusableArea( element ) { | |||
| * Returns all focusable elements within a given context. | |||
| * | |||
| * @param {Element} context Element in which to search. | |||
| * @param {Object} [options] | |||
| * @param {Object} options | |||
There was a problem hiding this comment.
kevin940726
requested review from
sarayourfriend,
youknowriad,
gziolo and
mirka
kevin940726
requested review from
ellatrix,
ajitbohra and
nerrad
as code owners
|
Flaky tests detected in a28ad60. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4270454351
|
kevin940726
force-pushed
the
upgrade/typescript
branch
from
1a0d75f to
a28ad60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Upgrade
typescriptto the latest version (4.4.2->4.9.5).Why?
Staying up-to-date.
How?
https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-5.html#breaking-changes
https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-6.html#breaking-changes
https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-7.html#breaking-changes
https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-8.html#correctness-fixes-and-breaking-changes
https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-9.html#correctness-fixes-and-breaking-changes
Testing Instructions