-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try to fix a11y test flakiness #48236
Conversation
Size Change: 0 B Total Size: 1.33 MB ℹ️ View Unchanged
|
Flaky tests detected in 298ada7. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4229362387
|
@kevin940726, I see the same failure reported inline for the code. |
😢 So sad... |
c0e00ba
to
78725bd
Compare
Staring at the e2e tests spinning icon to see if they pass 🙀 |
Okay, this seems to work now. I use a different approach by asserting the |
@kevin940726 good finding! So, to my understanding, it was a timing issue? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I ran the test just one more time, just to be sure 🙂
eae3392
to
298ada7
Compare
What?
Close #48067.
Why?
Fix the flakiness of the a11y test.
How?
Playwright runs too fast before the modal can run some of the code for constrained tabbing. We explicitly wait for
aria-label
to be sure thattabindex
has been updated. I'm not sure why it's only failing on Webkit though. This is not an ideal solution but I couldn't figure out a better one at the time. Let's merge this first to unblock other PRs, we can figure out a better solution in another PR.I ran this locally 100 times and they all passed.
Testing Instructions
CI should pass.