Navigation: Don't save the level of the link in an attribute #48219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -22 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in b8a2b93. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4323410848
|
This was referenced Feb 28, 2023
scruffian
commented
Mar 2, 2023
| * @param array $attributes Block attributes. | ||
| * @return array Colors CSS classes and inline styles. | ||
| */ | ||
| function block_core_navigation_link_build_css_colors( $context, $attributes ) { |
There was a problem hiding this comment.
I'm not sure why this was duplicated. I'd rather use the same function in both places. If we need to keep two copies of it, I'm not sure what we should do with this one - it never uses the $is_sub_menu branch, so we could just remove all that, but then it diverges from block_core_navigation_submenu_build_css_colors.
scruffian
commented
Mar 2, 2023
scruffian
force-pushed
the
update/overlay-colors-code
branch
from
edf02fc to
bd2be17
Compare
getdave
reviewed
Mar 2, 2023
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
getdave
reviewed
Mar 3, 2023
getdave
requested review from
talldan,
MaggieCabrera,
jeryj,
ajlende and
draganescu
scruffian
commented
Mar 3, 2023
getdave
approved these changes
Mar 3, 2023
getdave
added
the
Backport to WP 6.7 Beta/RC
|
@ntsekouras @Mamaduka I've added the backport label to this PR as I believe we need it to fix several bugs. I would prefer if more people could test it before it gets merged. |
MaggieCabrera
approved these changes
Mar 3, 2023
draganescu
requested changes
Mar 3, 2023
|
I have fixed that bug in 623d6f5 |
draganescu
approved these changes
Mar 3, 2023
scruffian
force-pushed
the
update/overlay-colors-code
branch
from
623d6f5 to
b8a2b93
Compare
|
🍾 🍾 🍾 🍾 🍾 🍾 |
ntsekouras
pushed a commit
that referenced
this pull request
Mar 7, 2023
* Don't save the level of the link in an attribute * reuse code * remove duplicate code * add extra escaping * Remove refactoring * update the doc block * fix linter * fix linter * remove double escape * Use existing truthy var for clarity in function call * Navigation Link blocks don't need submenu colors as this is set in the submenu block * fix linter --------- Co-authored-by: Dave Smith <[email protected]>
|
I just cherry-picked this PR to the wp/6.2 branch to get it included in the next release: e749760 |
ntsekouras
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The useEffect that saves the
isTopLevelLinkandisTopLevelItemto an attribute causes ripples through the other useEffects in the navigation block, which means that we get unexpected bugs like those listed below.I don't think we need this useEffect at all - we don't even need to know if this is a top level link. Instead we can output the colors on the navigation submenu wrapper element itself.
Closes #47829
Closes #48594
Closes #48668
Why?
I think this is a simpler approach and avoids the needs for a useEffect and extra attributes.
Testing Instructions
Testing Instructions for Keyboard
I suppose you'll have to inspect the code to ensure that the correct colors are applied.
Screenshots or screencast
Here are some disgusting colors:
