Navigation: Close Link UI if cancelled #48029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
[Type] Bug
getdave
requested review from
MaggieCabrera,
scruffian,
ajlende and
draganescu
|
Size Change: +18 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 87a7321. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4164719159
|
scruffian
approved these changes
Feb 14, 2023
There was a problem hiding this comment.
LGTM. It would be good if a keyboard user could also check it cc @alexstine...
DaisyOlsen
changed the title
|
I tested this with the KBD and it seems OK - focus moves back as it should to the inserter. |
|
No it doesn't as the changes to the Link UI to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Updates the Link UI component usage in the Nav block list view so that when the user hits
Cancelthe Link UI is closed.Closes #48014
Why?
Because currently
Canceldoes precisely nothing in this context.How?
Passes an
onCancelhandler which sets the state to hide the Link UI. Ensures the Link UI component passes the handler.Testing Instructions
CancelTesting Instructions for Keyboard
Screenshots or screencast
Screen.Capture.on.2023-02-13.at.14-56-44.mp4