Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Template Part: Performance: Replace usage of wp_get_theme()->get_stylesheet() with get_stylesheet() #48027

Merged
merged 1 commit into from
Feb 14, 2023
Merged

Template Part: Performance: Replace usage of wp_get_theme()->get_stylesheet() with get_stylesheet() #48027

merged 1 commit into from
Feb 14, 2023

Conversation

spacedmonkey
Copy link
Member

What?

Follow on from #57057.

Replace usage of wp_get_theme()->get_stylesheet() with get_stylesheet()

Why?

How?

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

@spacedmonkey spacedmonkey added the [Type] Performance Related to performance efforts label Feb 13, 2023
@spacedmonkey spacedmonkey self-assigned this Feb 13, 2023
@spacedmonkey spacedmonkey added the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Feb 13, 2023
felixarntz
felixarntz approved these changes Feb 14, 2023
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spacedmonkey LGTM, good catch!

anton-vlasenko
anton-vlasenko approved these changes Feb 14, 2023
View reviewed changes
Copy link
Contributor

@anton-vlasenko anton-vlasenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@spacedmonkey spacedmonkey merged commit 7a8a44a into trunk Feb 14, 2023
@spacedmonkey spacedmonkey deleted the fix/remove_wp_theme_usage branch February 14, 2023 20:45
@github-actions github-actions bot added this to the Gutenberg 15.2 milestone Feb 14, 2023
@DaisyOlsen DaisyOlsen changed the title Peformnace: Replace usage of wp_get_theme()->get_stylesheet() with get_stylesheet() Performance: Replace usage of wp_get_theme()->get_stylesheet() with get_stylesheet() Feb 14, 2023
@DaisyOlsen DaisyOlsen added the [Block] Template Part Affects the Template Parts Block label Feb 14, 2023
@DaisyOlsen DaisyOlsen changed the title Performance: Replace usage of wp_get_theme()->get_stylesheet() with get_stylesheet() Template Part: Performance: Replace usage of wp_get_theme()->get_stylesheet() with get_stylesheet() Feb 14, 2023
@DaisyOlsen DaisyOlsen added the [Package] Block library /packages/block-library label Feb 14, 2023
@ntsekouras ntsekouras added Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta and removed Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta labels Feb 20, 2023
ntsekouras pushed a commit that referenced this pull request Feb 21, 2023
@spacedmonkey @ntsekouras
Replace usage of wp_get_theme()->get_stylesheet() with get_stylesheet…
72c93fe 
…() (#48027)
@ntsekouras
Copy link
Contributor

I just cherry-picked this PR to the wp/6.2 branch to get it included in the next release: 72c93fe

@ntsekouras ntsekouras removed the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Feb 21, 2023
@spacedmonkey spacedmonkey added the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Mar 1, 2023
@Mamaduka
Copy link
Member

Mamaduka commented Mar 1, 2023

@spacedmonkey, this was already backported last week - #48027 (comment).

@Mamaduka Mamaduka removed the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Mar 1, 2023
@spacedmonkey spacedmonkey added the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Mar 1, 2023
@ntsekouras ntsekouras removed the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anton-vlasenko anton-vlasenko anton-vlasenko approved these changes

@felixarntz felixarntz felixarntz approved these changes

@Mamaduka Mamaduka Awaiting requested review from Mamaduka

@desrosj desrosj Awaiting requested review from desrosj

@gziolo gziolo Awaiting requested review from gziolo

@hellofromtonya hellofromtonya Awaiting requested review from hellofromtonya

@ntsekouras ntsekouras Awaiting requested review from ntsekouras

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees

@spacedmonkey spacedmonkey

Labels
[Block] Template Part Affects the Template Parts Block [Package] Block library /packages/block-library [Type] Performance Related to performance efforts
Projects
None yet
Milestone
Gutenberg 15.2
Development

Successfully merging this pull request may close these issues.
6 participants
@spacedmonkey @ntsekouras @Mamaduka @felixarntz @anton-vlasenko @DaisyOlsen