Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance: Tweaks to gutenberg_render_layout_support_flag #48003

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

spacedmonkey
Copy link
Member

What?

Improve performance of gutenberg_render_layout_support_flag function, by moving variables to places where is it needed.

Why?

How?

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

@github-actions
Copy link

github-actions bot commented Feb 13, 2023

Flaky tests detected in cf10ed3.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4159292716
📝 Reported issues:

@spacedmonkey spacedmonkey added the [Type] Performance Related to performance efforts label Feb 13, 2023
Copy link
Member

@aristath aristath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
The code makes sense, and it's a good practice to do this everywhere 👍

@spacedmonkey spacedmonkey merged commit 8892fde into trunk Feb 14, 2023
@spacedmonkey spacedmonkey deleted the fix/performancewp_render_layout_support_flag branch February 14, 2023 11:43
@github-actions github-actions bot added this to the Gutenberg 15.2 milestone Feb 14, 2023
@DaisyOlsen DaisyOlsen added the [Feature] Blocks Overall functionality of blocks label Feb 14, 2023
@spacedmonkey spacedmonkey added the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Feb 27, 2023
@ntsekouras ntsekouras added the Needs PHP backport Needs PHP backport to Core label Feb 27, 2023
@hellofromtonya
Copy link
Contributor

hellofromtonya commented Feb 27, 2023

Hey @spacedmonkey is this fixing a bug or regression?

If no, then it's an enhancement, which is too late for 6.2.

@hellofromtonya
Copy link
Contributor

In talking with Jonny, this is a code quality tweak for a performance enhancement. It's too late for it to go into 6.2. But it can backported to Core when 6.3 alpha opens (which will be next week).

@hellofromtonya hellofromtonya removed Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta Needs PHP backport Needs PHP backport to Core labels Feb 27, 2023
@hellofromtonya
Copy link
Contributor

https://core.trac.wordpress.org/ticket/57815 Trac ticket opened for this gutenberg-merge PR.

Removing the backport labels now that a Trac ticket is opened for its scope of work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks [Type] Performance Related to performance efforts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants