-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance: Tweaks to gutenberg_render_layout_support_flag #48003
Performance: Tweaks to gutenberg_render_layout_support_flag #48003
Conversation
Flaky tests detected in cf10ed3. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4159292716
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
The code makes sense, and it's a good practice to do this everywhere 👍
Hey @spacedmonkey is this fixing a bug or regression? If no, then it's an enhancement, which is too late for 6.2. |
In talking with Jonny, this is a code quality tweak for a performance enhancement. It's too late for it to go into 6.2. But it can backported to Core when 6.3 alpha opens (which will be next week). |
https://core.trac.wordpress.org/ticket/57815 Trac ticket opened for this Removing the backport labels now that a Trac ticket is opened for its scope of work. |
What?
Improve performance of gutenberg_render_layout_support_flag function, by moving variables to places where is it needed.
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast