Front-end classic performance test: set TwentyTwentyOne when running in isolation #47965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the metrics reported, it seems to be used when all test run. However, when running this single test (for example, locally), it still uses TwentyTwentyThree. So, make sure it is properly set in all scenarios.
oandregal
added
[Type] Build Tooling
youknowriad
approved these changes
Feb 10, 2023
oandregal
changed the title
|
Size Change: 0 B Total Size: 1.33 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 2705068. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4143272674
|
oandregal
deleted the
update/set-proper-classic-theme-front-end-metrics
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Makes sure TwentyTwentyOne is set as the theme for the front-end classic performance test suite.
Why?
According to the metric reports, it's properly sets when running the whole suite. However, when running this test in isolation (for example, locally), TwentyTwentyThree was in use instead. Make sure it's set properly for all scenarios.
How?
By activating it before the tests run.
Testing Instructions
Run the front-end classic test in isolation locally using puppeteer's interactive mode to verify that TwentyTwentyOne is in use:
npm run test:performance packages/e2e-tests/specs/performance/front-end-classic-theme.test.js -- --puppeteer-interactive --puppeteer-slowmo=200