-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update moment
and moment-timezone
packages to fix timezone issues
#47879
Update moment
and moment-timezone
packages to fix timezone issues
#47879
Conversation
BeforeAfter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tested the changes, but they look correct and all CI cheks still pass. I can confirm that the version of moment
aligns now with WordPress core:
The only caveat is that in core, it's pinned and here we correctly allow newer versions to avoid locking 3rd party package consumers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Mamaduka or @ntsekouras – is it something you would be fine adding to the scope of the WordPress 6.2 release? |
@gziolo matching the library versions makes sense to me 👍 |
Cherry-picked this PR to the wp/6.2 branch. |
What?
In this PR, I propose to update the
moment
andmoment-timezone
packages to match the versions used by WP core.Why?
It should fix the timezone-related issues e.g. Automattic/wp-calypso#71529 and fix #47698
How?
moment-timezone
package is being updated to catch with IANA time zone database changes. Last year some time zones were renamed e.g. Kiev to Kyiv (moment/moment-timezone#986). This update should fix issues for such timezone, and possibly it will fix other issues related to timezones.Testing Instructions
Testing Instructions for Keyboard
N/A
Screenshots or screencast