Site editor: specify active state color for template navigation button #47851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glendaviesnz
added
[Type] Bug
|
Size Change: +24 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in fc7de92. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4118501928
|
apeatling
approved these changes
Feb 7, 2023
glendaviesnz
added
Backport to WP 6.7 Beta/RC
|
I just cherry-picked this PR to the release/15.1 branch to get it included in the next release: dbc7928 |
juanmaguitar
pushed a commit
that referenced
this pull request
Feb 8, 2023
juanmaguitar
removed
the
Backport to Gutenberg RC
ntsekouras
pushed a commit
that referenced
this pull request
Feb 9, 2023
|
Cherry-picked this PR to the wp/6.2 branch. |
ntsekouras
removed
the
Backport to WP 6.7 Beta/RC
youknowriad
added
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Sets the active state color of template navigation back icon
Why?
So it doesn't disappear when you click on it.
Fixes: #47805
How?
Set the color on
:active, and combines with:not([aria-disabled="true"])so specificity is high enough to override the default.Testing Instructions
Screenshots or screencast
Before:
template-before.mp4
After:
template-after.mp4