Refactor: usePatternsCategories: simplify category sorting #47843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcsf
added
[Type] Code Quality
|
Size Change: -4 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 5385582. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4122861069
|
mcsf
force-pushed
the
refactor/use-patterns-categories-sorting
branch
from
98fa2a7 to
5385582
Compare
ellatrix
reviewed
Feb 8, 2023
| // 1. The categories from `patternCategoriesOrder` in that specific order should be at the top. | ||
| // 2. The rest categories should be at the bottom without any re-ordering. | ||
| if ( | ||
| ! [ currentName, nextName ].some( ( categoryName ) => |
There was a problem hiding this comment.
Right, nice to avoid all these nested loops.
|
Thank you for the simplification Miguel! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows up on #47760.
What?
Just a minor refactor which I hope makes the sorting in
usePatternsCategorieseasier to understand at a glance.Testing Instructions