Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick CLI: Fix the default label to match the documentation #47832

Merged
merged 1 commit into from
Feb 7, 2023
Merged

Cherry-pick CLI: Fix the default label to match the documentation #47832

merged 1 commit into from
Feb 7, 2023

Conversation

Mamaduka
Copy link
Member

@Mamaduka Mamaduka commented Feb 7, 2023

What?

PR updates the default label match documentation and the label mentioned in original PR #40969.

Why?

@ntsekouras discovered that the default label mentioned in the documentation doesn't match the CLI default. We use this command more often during Beta/RC release, so I think this label makes more sense as the dafault.

Testing Instructions

  1. Run cherry-picking command without an argument - npm run other:cherry-pick
  2. Confirm it uses the correct default label.
  3. Cancel the command by typing n.

Screenshots or screencast

CleanShot 2023-02-07 at 17 03 11

@Mamaduka Mamaduka requested review from gziolo and adamziel and removed request for ntwb, ajitbohra and nerrad February 7, 2023 13:08
@Mamaduka Mamaduka self-assigned this Feb 7, 2023
@Mamaduka Mamaduka added [Type] Bug An existing feature does not function as intended [Type] Project Management Meta-issues related to project management of Gutenberg Developer Experience Ideas about improving block and theme developer experience labels Feb 7, 2023
ntsekouras
ntsekouras approved these changes Feb 7, 2023
View reviewed changes
Copy link
Contributor

@ntsekouras ntsekouras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you George!

@Mamaduka Mamaduka merged commit 736ace6 into trunk Feb 7, 2023
@Mamaduka Mamaduka deleted the fix/cherry-pick-cli-default-label branch February 7, 2023 13:46
@github-actions github-actions bot added this to the Gutenberg 15.2 milestone Feb 7, 2023
ntsekouras pushed a commit that referenced this pull request Feb 13, 2023
@Mamaduka @ntsekouras
Cherry-pick CLI: Fix the default label to match the documentation (#4…
b14f22b 
…7832)
@ntsekouras
Copy link
Contributor

Cherry-picked this PR to the wp/6.2 branch.

@adamziel
Copy link
Contributor

Cherry-picked this PR to the wp/6.2 branch.

So meta!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntsekouras ntsekouras ntsekouras approved these changes

@gziolo gziolo Awaiting requested review from gziolo

@adamziel adamziel Awaiting requested review from adamziel

Assignees

@Mamaduka Mamaduka

Labels
Developer Experience Ideas about improving block and theme developer experience [Type] Bug An existing feature does not function as intended [Type] Project Management Meta-issues related to project management of Gutenberg
Projects
None yet
Milestone
Gutenberg 15.2
Development

Successfully merging this pull request may close these issues.
3 participants
@Mamaduka @ntsekouras @adamziel