Dependency Extraction Webpack Plugin: Update json2php dependency #47831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
[Type] Bug
gziolo
force-pushed
the
update/dewp-dependency-json2php
branch
from
27c83ae to
aeb69da
Compare
|
Size Change: 0 B Total Size: 1.31 MB ℹ️ View Unchanged
|
|
Flaky tests detected in aeb69da. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4113919382
|
youknowriad
approved these changes
Feb 7, 2023
desrosj
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
There were some issues with
json2phppackage during the process of backporting changes from the Gutenberg repository to WordPress core described by @youknowriad in https://core.trac.wordpress.org/ticket/57471#comment:17. The resolution required to bringjson2phpto the latest version with the following commit from @desrosj: https://core.trac.wordpress.org/changeset/55232.Why?
We don't have any evidence that there is any issue with the
@wordpress/dependency-extraction-webpack-pluginbecause of the potential usage ofjson2phpin version0.0.5or0.0.6but I would prefer to stay on the safe side and prevent that if possible,How?
The bundled
json2phpdependency has been upgraded from requiring^0.0.5to^0.0.7for@wordpress/dependency-extraction-webpack-plugin.Testing Instructions
All unit tests for the
@wordpress/dependency-extraction-webpack-pluginshould still pass. In general, there should be no impact on CI jobs.