LocalAutosaveNotice: use stable notice id to prevent double notices #47776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsnajdr
added
the
Backport to WP 6.7 Beta/RC
jsnajdr
changed the title
|
Size Change: -10 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in c2086ea. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4103472326
|
ntsekouras
reviewed
Feb 6, 2023
| window.sessionStorage.removeItem( '__wpEditorTestSessionStorage' ); | ||
| hasStorageSupport = true; | ||
| } catch { | ||
| hasStorageSupport = false; |
There was a problem hiding this comment.
Shouldn't we return the value in this try/catch block?
There was a problem hiding this comment.
I'd say we should return it after the try / catch block. Seems like in this branch we no longer return it at all in this function.
There was a problem hiding this comment.
Pushed a fix 👍 The return statement must have got lost during a git add -p when I wanted to commit the changes as two commits.
jsnajdr
force-pushed
the
dedupe/autosave-notice
branch
from
1a399ce to
c2086ea
Compare
tyxla
approved these changes
Feb 6, 2023
Comment on lines
+33
to
+34
| if ( hasStorageSupport !== undefined ) { | ||
| return hasStorageSupport; |
There was a problem hiding this comment.
I can't think of a rational reason to need to run it multiple times 👍
ntsekouras
pushed a commit
that referenced
this pull request
Feb 7, 2023
…47776) * LocalAutosaveNotice: use stable notice id to prevent double notices * Some code cleanups (bailout, catch, useSelect)
|
Cherry-picked this PR to the wp/6.2 branch. |
ntsekouras
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue in React strict mode where local autosave notice appears twice, reported by @ntsekouras here: #47703 (comment)
The notice is created in
useEffect, and on mount, React strict mode runs effects twice.I fixed this by giving a stable ID to the notice, instead of making it unique on each call. If the notice is created for the second time, the previous one gets removed. The unique ID was never really needed -- this is the kind of notice that should appear only once.