Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gallery: Minor code quality update #47774

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

ntsekouras
Copy link
Contributor

What?

Minor update to address @felixarntz review here: https://github.com/WordPress/wordpress-develop/pull/3914/files#r1095179123

Testing Instructions

  1. Gallery block should work as before.

@ntsekouras ntsekouras added [Type] Code Quality Issues or PRs that relate to code quality Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta labels Feb 6, 2023
@ntsekouras ntsekouras requested a review from geriux as a code owner February 6, 2023 09:57
@ntsekouras ntsekouras self-assigned this Feb 6, 2023
@github-actions
Copy link

github-actions bot commented Feb 6, 2023

Flaky tests detected in 2c82685.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4102422216
📝 Reported issues:

@ntsekouras ntsekouras merged commit 4f0160e into trunk Feb 6, 2023
@ntsekouras ntsekouras deleted the refactor/gallery-array-code-quality branch February 6, 2023 11:25
@github-actions github-actions bot added this to the Gutenberg 15.2 milestone Feb 6, 2023
@ntsekouras
Copy link
Contributor Author

Cherry-picked this PR to the wp/6.2 branch.

@ntsekouras ntsekouras removed the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Feb 7, 2023
@felixarntz
Copy link
Member

Thank you @ntsekouras, apologies I missed this yesterday!

@DaisyOlsen DaisyOlsen added the [Block] Gallery Affects the Gallery Block - used to display groups of images label Feb 14, 2023
@DaisyOlsen DaisyOlsen changed the title [Block Library - Gallery]: Minor code quality update Gallery: Minor code quality update Feb 14, 2023
@DaisyOlsen DaisyOlsen added the [Package] Block library /packages/block-library label Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Gallery Affects the Gallery Block - used to display groups of images [Package] Block library /packages/block-library [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants