Image: Allow deprecated blocks to render border-radius #47766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
added
[Type] Bug
|
Size Change: +79 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in d23603a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4099929200
|
glendaviesnz
approved these changes
Feb 7, 2023
There was a problem hiding this comment.
This tested well for me. With this PR applied:
✅ Images added to 6.0.1 with border radius displayed radius as expected in frontend with site updated to 6.1.1
✅ When same images loaded in editor the deprecations ran and style was moved to inner element so additional border radius CSS no longer applied
✅ Radius added to theme.json displayed as expected in editor and frontend, and was overridden by any user applied radius
✅ Correct radius displayed in image cropping tool
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #47422
What?
Allows deprecated Image blocks to continue rendering custom image border radii without resaving the posts.
Why?
Without this change, deprecated image blocks lose their border radii on the frontend.
How?
border-radiusstyle present on deprecated image blocks. This style forces the image blocksimgto inherit the border radiusTesting Instructions
Screenshots or screencast
Frontend - Deprecated Image block with custom border radius
Editor - Cropping image with custom border radius & theme.json border radius style
Note: In before image above, a theme.json border-radius of
100pxwas being applied to the innerimgwhile the cropper possessed the correct custom border radius of50px.