Table Block: Don't render empty section #47753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
changed the title
t-hamano
added
[Type] Code Quality
|
Size Change: -2 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 14e3bea. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4091004146
|
talldan
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This small PR changes the editor to not render sections without rows (
thead/tfoot).Why?
To match the front-end rendering results.
I also discovered that this issue affects when implementing caption toolbar buttons, as was done in #45112 and #47325. If the caption is hidden, an empty tfoot tag will cause unexpected scrolling.
ce999fbf1f211ebf91ec6d870facb14f.mp4
How?
When each section is rendered, I used a
sectionsvariable with empty sections removed instead of a hard-coded section array.Testing Instructions
After inserting a table with no header/footer, confirm that it only has a
tbodyelement directly below thetabletag.