useBlockSync: change subscribed.current on unsubscribe #47752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsnajdr
added
the
Backport to WP 6.7 Beta/RC
|
Size Change: +2 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
ntsekouras
approved these changes
Feb 6, 2023
|
Cherry-picked this PR to the wp/6.2 branch. |
ntsekouras
added
[Type] Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed broken undo in strict mode reported by @ntsekouras here: #47703 (comment)
Was caused by missing
subscribed.current = falsewhen cleaning up an effect and unsubscribing. In another effect in the same hook, there is code like:which says "assign to
incomingchanges if already subscribed", and "already subscribed" is the same as "this is not the first, initial run of the effect". In other words, we want to assign toincomingonly when the blocks change, not their initial value.How to test: Test this together with
<StrictMode>in the post editor, and verify that undo works. Undo was broken when you did the first change, on subsequent changes it started working again.