Lodash: Remove from @wordpress/keycodes package
#47737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Performance
tyxla
requested review from
Mamaduka,
sgomes,
aristath,
jsnajdr,
gziolo,
swissspidy,
flootr,
chad1008,
ntsekouras,
fabiankaegy and
brookewp
|
Size Change: +41 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
Feb 3, 2023
|
Flaky tests detected in b4cd36b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4084686576
|
|
@Mamaduka, it would be great to include in WP 6.2 🙌🏻 |
ntsekouras
pushed a commit
that referenced
this pull request
Feb 13, 2023
* Lodash: Refactor away from _.get() in @wordpress/keycodes * Lodash: Refactor away from _.mapValues() in @wordpress/keycodes * Lodash: Remove dependency from @wordpress/keycodes
|
Cherry-picked this PR to the wp/6.2 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes all of the Lodash from the
@wordpress/keycodespackage. There are just a few usages and conversion is pretty straightforward.Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetchpackage haslodashas a dependency #39495A motivation to remove Lodash from the
@wordpress/keycodespackage is that it's the last one that needslodashand is a dependency of the widely used@wordpress/composepackage.How?
The PR looks large, but that's mostly whitespace changes, due to the TS changes required for the custom
mapValues()implementation. I recommend ignoring whitespace changes while reviewing.We have to deal with essentially a couple of methods, and migration away from them is pretty straightforward:
getReplacing
getis as simple as using direct access, and optional chaining with nullish coalescing.mapValuesStraightforward to replace it with a custom implementation that uses
Object.fromEntries( Object.entries().map() ). Needs a bit of type massaging as well.Finally, we're removing the
lodashdependency from the package completely.Testing Instructions
Code is covered by tests - verify all tests pass and all checks are green.