Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add <LinkControl> code owner #47733

Merged
merged 1 commit into from
Feb 3, 2023
Merged

Conversation

getdave
Copy link
Contributor

@getdave getdave commented Feb 3, 2023

What?

Adds @getdave (that's me) as a codeowner of the Link Control.

Why?

I have made a lot of changes to the component and know it well but I"m missing incoming PRs. This should help.

How?

Adds me to CODEOWNERS file.

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

@getdave getdave added the [Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) label Feb 3, 2023
@getdave getdave requested a review from scruffian February 3, 2023 12:18
@getdave getdave self-assigned this Feb 3, 2023
@getdave getdave changed the title Add link control code owner Add <LinkControl> code owner Feb 3, 2023
@github-actions
Copy link

github-actions bot commented Feb 3, 2023

Flaky tests detected in 4e16cac.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4084070130
📝 Reported issues:

@getdave getdave merged commit f1f3b96 into trunk Feb 3, 2023
@getdave getdave deleted the add/getdave-as-link-control-codeowner branch February 3, 2023 12:50
@getdave
Copy link
Contributor Author

getdave commented Feb 3, 2023

Thank you @carolinan 🙇

@github-actions github-actions bot added this to the Gutenberg 15.2 milestone Feb 3, 2023
@DaisyOlsen DaisyOlsen added the [Type] Enhancement A suggestion for improvement. label Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants