Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make process_blocks_custom_css method protected #47725

Merged
merged 1 commit into from
Feb 6, 2023
Merged

Make process_blocks_custom_css method protected #47725

merged 1 commit into from
Feb 6, 2023

Conversation

aristath
Copy link
Member

@aristath aristath commented Feb 3, 2023

What?

Following the comments on #46571 (comment) and WordPress/wordpress-develop#3977 (comment), this PR changes the visibility of the process_blocks_custom_css from public to protected.

Why?

To avoid exposing the method publicly

How?

Changed the visibility of the method, and then used ReflectionMethod in PHPUnit tests.

Testing Instructions

Nothing to test. If PHP tests pass, this is good to go.

@aristath aristath mentioned this pull request Feb 3, 2023
Closed
@aristath aristath added the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Feb 3, 2023
@Mamaduka
Copy link
Member

Mamaduka commented Feb 3, 2023

There's no need to backport since changes are already handled in core PR 👍

@Mamaduka Mamaduka added [Type] Task Issues or PRs that have been broken down into an individual action to take [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") and removed Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta labels Feb 3, 2023
@github-actions
Copy link

github-actions bot commented Feb 3, 2023

Flaky tests detected in 23ea2a6.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4082417266
📝 Reported issues:

@aristath aristath merged commit b0f945d into trunk Feb 6, 2023
@aristath aristath deleted the fix/process_blocks_custom_css-visibility branch February 6, 2023 08:47
@github-actions github-actions bot added this to the Gutenberg 15.2 milestone Feb 6, 2023
@oandregal
Copy link
Member

Thanks for following up

@juanmaguitar juanmaguitar added the [Type] Code Quality Issues or PRs that relate to code quality label Feb 15, 2023
@juanmaguitar juanmaguitar mentioned this pull request Feb 15, 2023
Closed
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mamaduka Mamaduka Mamaduka approved these changes

@oandregal oandregal Awaiting requested review from oandregal

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey

Assignees
No one assigned
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Code Quality Issues or PRs that relate to code quality [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Milestone
Gutenberg 15.2
Development

Successfully merging this pull request may close these issues.
4 participants
@aristath @Mamaduka @oandregal @juanmaguitar