Components: Remove unnecessary act() from Popover tests
#47690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Code Quality
tyxla
requested review from
Mamaduka,
mirka,
jsnajdr,
ciampo,
flootr,
chad1008,
ntsekouras and
brookewp
|
Flaky tests detected in a9bd72b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4082937127
|
ciampo
approved these changes
Feb 2, 2023
| const popover = screen.getByTestId( 'popover-element' ); | ||
|
|
||
| await waitFor( () => expect( popover ).toBeVisible() ); | ||
| await waitFor( () => expect( popover ).toHaveFocus() ); |
There was a problem hiding this comment.
Why is the double await necessary? Should we add an inline comment with the explanation?
There was a problem hiding this comment.
It's not necessary actually. I've cleaned the second one up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR cleans up a few unnecessary
act()calls and improves some of thePopovertests.Why?
When preparing our tests to work with React 18 we did a bunch of those
act()calls. It's time to clean them up where possible.How?
actcall.renderAsync()helper and inlining the rendering for clarity and simplicity. IMO it wasn't adding value to the tests, but rather was creating indirection when reading the tests.Testing Instructions
Verify tests still pass:
npm run test:unit packages/components/src/popover/test/index.tsxTesting Instructions for Keyboard
None
Screenshots or screencast
None