Navigation: Enable undo after creating a new menu #47683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draganescu
added
[Type] Bug
|
Size Change: -86 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 74c77d21f3f38ca3f7f6519261061b0103b8528b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4104222269
|
talldan
reviewed
Feb 3, 2023
packages/block-library/src/navigation/edit/use-create-navigation-menu.js
Outdated
Show resolved
Hide resolved
getdave
reviewed
Feb 3, 2023
There was a problem hiding this comment.
It's great this is being addressed. It's been a problem for too long. Thank you.
This seemed to work well for the basic use case.
I'm not 100% but I think I found a bug:
- Nav block with existing menu set
- Create new menu
- Create a menu item in that menu
- Click undo until you get back to your original menu (the one you had at the start)
- Now click redo - notice how you cannot get back to the new menu with the newly created item 😞
Screen.Capture.on.2023-02-03.at.11-16-05.mp4
|
@getdave do you think that is that a bug caused by this PR? Because testing in trunk is weird since in trunk you can't get back at all :) |
I honestly have no idea. I doubt it's directly caused by it although it obviously could be. I'd vote for merging this one and following up to see if we can fix the issue I encountered. |
getdave
approved these changes
Feb 3, 2023
draganescu
force-pushed
the
fix/undo-create-navigation
branch
from
27c6551 to
74c77d2
Compare
|
Hi @fluiddot :) me again! This PR removes and effect from the navigation block and somehow it causes a React test to fail:
Can you please 🙏🏻 point me to something I can start to investigate? |
…dds it to the create menu hook
Co-authored-by: Daniel Richards <[email protected]>
draganescu
force-pushed
the
fix/undo-create-navigation
branch
from
74c77d2 to
7bdc00e
Compare
Thanks @draganescu for the call out 🙇. I checked the changes introduced in this PR and in this case, the failure on the mobile E2E tests seems unrelated and most likely caused due to flakiness in those tests. Let's try to restart them and check again if they succeed 🤞. UPDATE: As we speak, we are currently working on making the mobile E2E tests more stable. |
|
@fluiddot awesome! I will then merge this with this test failing. I want to make sure it makes it in 6.1 and it already failed to land in the beta. Thank you for the help! Geronimo! |
draganescu
added
the
Backport to WP 6.7 Beta/RC
ntsekouras
pushed a commit
that referenced
this pull request
Feb 9, 2023
* removes the publish status effect from navigation edit componet and adds it to the create menu hook * Only edit in memory for Drafts Co-authored-by: Daniel Richards <[email protected]> --------- Co-authored-by: Daniel Richards <[email protected]>
|
Cherry-picked this PR to the wp/6.2 branch. |
ntsekouras
removed
the
Backport to WP 6.7 Beta/RC
DaisyOlsen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Advances #46476
When creating a new menu, undo does not do anything although it is available. This PR fixes that allowing undo to go back to the previously selected menu.
Why?
Because creating a new menu should be undoable somehow, particularly since the names of the menus are quite similar by default so it's confusing to know which one was selected before. Plus the undo button showed it should work.
How?
The Navigation edit component had an effect which set the newly created navigation to a publish status. That served two purposes:
This PR removes this effect which somehow broke the undo. It moves the in memory edit right after the menu is created, in the hook which provides the menu creation procedure.
Undoing a menu creation does not delete the newly created menu, it only restores the previously selected menu.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
working-undo-create.mp4