Avatar: Fix application of borders #47630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
added
[Type] Bug
aaronrobertshaw
requested review from
spacedmonkey and
ajitbohra
as code owners
|
Size Change: +515 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 83686bb. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4070517212
|
carolinan
approved these changes
Feb 1, 2023
andrewserong
approved these changes
Feb 2, 2023
There was a problem hiding this comment.
Nice one, logic looks good and this is testing well for me:
✅ Avatar block with uniform sides is output correctly in post editor and on site frontend
✅ Avatar block with non-uniform sides is output correctly in post editor and on site frontend
✅ Tested in a blocks-theme and with TwentyTwenty theme with appearance tools enabled
Only issue I noticed is that I think there's a no-longer-needed call to safecss_filter_attr, but other than that this LGTM ✨ — good idea splitting the logic into a separate utility function, it helps the readability 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #47408
What?
Ensures border classes and styles are correctly applied to the avatar block's markup.
Note: The original issue notes this as an issue for classic themes however it should be a problem for block themes as well.
Why?
The avatar block adopts border supports and skips the serialization of the support classes and styles so they can be applied to an inner image element. Given the block skips serialization it must handle the application of all border configurations and it is currently missing the handling of split or "individual" borders.
How?
box-sizing: border-boxreset to the block'simgelement so borders don't break out of the avatar's sizing.Testing Instructions
Screenshots or screencast
Screen.Recording.2023-02-01.at.5.50.01.pm.mp4
Screen.Recording.2023-02-01.at.6.05.35.pm.mp4