Remove lodash mapKeys usage #47600
Merged
Remove lodash mapKeys usage #47600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Code Quality
|
Size Change: -13 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 629dc05. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4053157366
|
|
@youknowriad looks like this might have broken the performance results logger. I see no more data in https://codehealth.vercel.app/ and this is the first commit that's missing. Filed a potential fix in #47646. |
|
Another fix here: #47650 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #47442 to address this comment #47442 (review)
What?
We're in a middle of an effort to remove lodash from our dependencies. This PR replaces mapKeys with a Object.keys + reduce