Add layout child sizing to Navigation block #47584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tellthemachines
added
[Block] Navigation
tellthemachines
requested review from
scruffian,
MaggieCabrera,
andrewserong and
apeatling
|
Size Change: +24 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in cf49273. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4050871304
|
tellthemachines
force-pushed
the
add/child-layout-size-to-nav
branch
from
ce86ca7
to
cf49273
Compare
MaggieCabrera
approved these changes
Jan 31, 2023
There was a problem hiding this comment.
This is working as intended! Thank you for adding this. While trying to recreate the design that @beafialho was aiming for with Fewer I fouwnd these extra margins on the navigation block that cannot be removed within the editor. We should try and address those in a separate PR:
|
Thanks for reviewing folks!
Those seem to be coming from here; @jasmussen might know more. |
18 tasks
82 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Allows adding custom sizes to Navigation block children, and fixes a bug in
hasChildLayoutSupportthat wasn't taking into account the possible shapes of the parent layout object.Note: this PR depends on #47477 in order to work correctly, because currently the Nav block edit function is passing the wrong layout config to its inner blocks.Edit: now that #47477 is merged and I've rebased this branch, this PR can be tested as-is.
Testing Instructions
Because of the dependency on #47477, is probably best to check out that branch and then apply this PR as a diff on top of it. Once it's built locally, you can:Note: for vertical Navs, the children will display a "Height" control, but in order for the "Fill" option to work the Nav block will need to have a fixed height value. Given the Nav block doesn't seem to have a min-height control available yet, the only way to do this is to stick the Nav inside a Row block with a sibling that is taller than itself, and set the Row vertical alignment (in the block toolbar) to "stretch".
Testing Instructions for Keyboard
Screenshots or screencast
Nav item with fixed size in px: