Fix and simplify the Modal dialog close button label #47540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
added
[Type] Bug
afercia
requested review from
ajitbohra,
kevin940726,
ntwb,
nerrad,
noisysocks,
draganescu,
talldan,
tellthemachines,
adamziel and
ellatrix
as code owners
|
Size Change: -122 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
carolinan
approved these changes
Jan 30, 2023
There was a problem hiding this comment.
This makes sense and when I test the lock modal in the block editor, the aria-label and tooltip is correct.
I also tried the template part creation modal in the site editor. I added a template part and selected "Start blank". The button has the correct aria-label (Close) but it has no tooltip.
This missing tooltip seems unrelated to this PR.
I do not know if the tooltip has been removed intentionally: Without Gutenberg active, the lock modal and template part creation modal has tooltips. But with Gutenberg 15 or trunk active, there are no tooltips.
Mamaduka
approved these changes
Jan 30, 2023
Good catch. This appears to be a regression. The tooltip is rendered but it's hidden behind the modal. Will create a new issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #47491
What?
There are several occurrences of the Modal usage where the passed prop name for the close button label is, incorrectly,
closeLabel. It should becloseButtonLabel. All the strings passed via closeLabel don't have any effect and the default string Close dialog is actually rendered.Why?
The Close button should have a meaningful, simple, label.
How?
Instead of fixing the prop name, I'd like to propose to just remove the passed props and simplify the default from 'Close dialog' to 'Close':
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast