-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update npx commands in create-block README.md #47150
Conversation
Update npx commands to ensure latest version is in use. I followed these directions and it used an old version, which resulted in various flags not working.
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @doughamlin! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
Thank you for the report. It looks like it was a bug on npm side: npm/cli#2329. It's been fixed shortly after v7.19.0. There is also a following note in the comments:
So maybe an alternative would be adding a note to use |
Is it a bug or the intended behavior of npx? Commenters in that ticket (as well as other discussions I referenced before opening this PR) don't seem to agree. Either way, it seems not ideal that someone can't copy/paste these commands and expect them to work. For the record, I was using npx v8.1.0, and that ticket says the bug was fixed in v7.5.2. If I run So, it seems anyone who comes back and tries to use a new flag with npx will face a similar result as me. A note to add |
In that case, it might be fine to include the @ryanwelcher, @juanmaguitar and @mburridge, do you agree? We might need to update more places for consistency or include a Troubleshooting section to use as a reference. |
I think I would prefer a note on the page to append |
@doughamlin Thanks for opening this PR. |
Congratulations on your first merged pull request, @doughamlin! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts: https://profiles.wordpress.org/me/profile/edit/ And if you don't have a WordPress.org account, you can create one on this page: https://login.wordpress.org/register Kudos! |
What?
Update npx commands to ensure latest version is used.
Why?
I followed these directions and it used an old version, which resulted in various flags not working.
How?
Update the readme
Testing Instructions
N/A