Fix misaligned layout control icons #47089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richtabor
added
[Feature] Layout
|
Size Change: +1.28 kB (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 40f1157. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/3936850929
|
|
It looks like there's now a gap between the two inputs and the related help text below them, and that shouldn't be there. It's this style that causes it: Toggling that off fixes both the spacing between the inputs and the help text, and also fixes the icon alignment. I guess that margin needs to be removed somehow. |
mirka
reviewed
Jan 16, 2023
There was a problem hiding this comment.
I noted a minor detail, but in general I think this is a reasonable workaround 👍
It's this style that causes it
Yes, the overscoped style in the block inspector is unfortunate, but it isn't going away any time soon. There are talks of a better alternative (#43423), but even so I think that style will take a long time to phase out. Just adding some context for posterity 🙂
| @@ -10,6 +10,10 @@ | |||
| margin: auto 0 $grid-unit-05 $grid-unit-10; | |||
| } | |||
| } | |||
|
|
|||
| .components-input-control { | |||
There was a problem hiding this comment.
For robustness, I would recommend passing your own classNames to the UnitControls (.block-editor-hooks__something), or scoping it to .components-unit-control at the very least since it isn't a given that UnitControls will always have a .components-input-control class under the hood.
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Apply
automargin-bottom to vertically center the layout controls again. Closes #47088.Why?
The icons are no longer where they should be. Look fine in WordPress core, but not in Gutenberg.
How?
Minor style change.
Testing Instructions
Screenshots or screencast
Before:
After: