Sidebar Tabs: Add text only mode for block inspector tabs #46968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +962 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 02bde25. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/3880223905
|
ntsekouras
reviewed
Jan 9, 2023
packages/block-editor/src/components/inspector-controls-tabs/use-inspector-controls-tabs.js
Outdated
Show resolved
Hide resolved
aaronrobertshaw
changed the title
aaronrobertshaw
added
[Type] Enhancement
This was referenced Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #46871
What?
Display textual labels for the Block Inspector tabs when the "Show button text labels" preference is set.
Why?
It brings the inspector tabs more in line with the main editor and block toolbars when the "Show button text labels" option is set.
How?
Uses a similar CSS approach to the main and block toolbars. The difference is that the
aria-labeltext is set as the content on the::beforepseudo element as::afteris already used for styling a TabPanel's active tab.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast