SlotFill: Remove knobs in stories #46957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.32 MB ℹ️ View Unchanged
|
mirka
commented
Jan 7, 2023
| @@ -11,19 +6,21 @@ import { createContext, useContext } from '@wordpress/element'; | |||
| /** | |||
| * Internal dependencies | |||
| */ | |||
| import { Slot, Fill, Provider } from '../'; | |||
| import { Slot, Fill, Provider as SlotFillProvider } from '../'; | |||
There was a problem hiding this comment.
Renaming to match the name of the public export so it's more understandable in the code snippets.
Comment on lines
-41
to
-42
| const name = text( 'name', 'Grace' ); | ||
| const age = number( 'age', 33 ); |
There was a problem hiding this comment.
Controls aren't very helpful for these components so I think we can remove them altogether. Separate stories with good usage examples and descriptions are a better fit. (We can add better descriptions in the full TypeScript refactor.)
|
Flaky tests detected in 5ebf7e5. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/3859553989
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #35665
What?
Remove the Knobs add-on from
SlotFillstories.Why?
This is now a blocker for supporting npm 8 (#46443).
How?
Just a quick, minimal refactor.
Testing Instructions
npm run storybook:devSlotFillcomponent.