Toolbar: fix duplicate focus style on anchor link button #46759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Package] Components
|
Size Change: -8 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
priethor
added
[Focus] Accessibility (a11y)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46757
What?
This PR fixes a problem in which two focus outlines are displayed when the anchor link button is used in the
Toolbarcomponent. As seen in this image, the Edit button in the template part is the anchor link button.Why?
In the
Toolbarcomponent, the following code overrides the focus style inherited from theButtoncomponent:gutenberg/packages/components/src/toolbar/style.scss
Lines 23 to 27 in f303663
I think that the
aelement doesn't support the:disabledpseudo-element, and as a result, the:enabledpseudo-element does not work. Also, if you look at the HTML standard, you will see that the:enabledpseudo-element does not support theaelement.How?
I used
:not(:disabled)instead of:enabled. This also matches theaelement, which does not support:disabled/:enabled.Testing Instructions
Screenshots or screencast
I also tested in Windows high contrast mode.
Before
before_default.mp4
before_contrast.mp4
After
after_default.mp4
after_contrast.mp4