Gallery: Avoid creating new layout objects on every render #46715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Performance
youknowriad
approved these changes
Dec 21, 2022
|
Size Change: +3 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
|
The default value is Update: Specifying empty alignments is needed to disable them for inner blocks. P.S. The Navigation block uses the same setting. |
|
Thanks for checking @Mamaduka |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Similar to #30374.
Updates Gallery block to use stable reference object for the layout settings.
Why?
I noticed that the
ImageEditcomponent was doing extra rerender due to context and__unstableParentLayoutchange. Also, it's a good practice if the setting isn't reactive value.Testing Instructions
The Gallery block should work as before.