Navigation Sidebar: Hide behind the experiment flag #46710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruffian
added
the
[Feature] Navigation in Site View
|
Size Change: +11 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
Copons
reviewed
Dec 21, 2022
| @@ -69,7 +69,7 @@ export function SidebarComplementaryAreaFills() { | |||
| // See https://github.com/WordPress/gutenberg/blob/trunk/docs/how-to-guides/feature-flags.md#dead-code-elimination. | |||
| let MaybeNavigationMenuSidebar = Fragment; | |||
|
|
|||
| if ( process.env.IS_GUTENBERG_PLUGIN ) { | |||
| if ( window?.__experimentalEnableOffCanvasNavigationEditor === true ) { | |||
There was a problem hiding this comment.
Non-blocking note: other (most?) experimental flags are assigned to a variable before use.
E.g.
const isOffCanvasNavigationEditorEnabled =
window?.__experimentalEnableOffCanvasNavigationEditor === true;
if ( isOffCanvasNavigationEditorEnabled ) {
// ...
}The only other occurrence I could find of the global used directly is another off-canvas nav flag:
Whatever, not a big deal, IMHO. 🙂
Copons
approved these changes
Dec 21, 2022
|
Ok let's bring this in. If there are concerns we can always revert! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This changes the conditions under which we make the navigation sidebar visible.
Why?
As raised in Automattic/wp-calypso#71278, this sidebar is quite broken and not a great experience. We hope that the Navigation List View experiment will improve this experience, so lets make this sidebar dependent on that flag being enabled.
How?
Just changing the conditional
Testing Instructions
Testing Instructions for Keyboard
As above
Screenshots or screencast
With the experiment flag disabled:
With the experiment flag enabled:
