Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: missing links in block.json schema #46694

Merged
merged 1 commit into from
Dec 21, 2022
Merged

Conversation

t-hamano
Copy link
Contributor

@t-hamano t-hamano commented Dec 21, 2022

What?

This PR fixes two missing links among the URLs present in the schema of block.json.

How?

Please check the comments that follow.

Testing Instructions

No impact on code.

"description": "Although attributes may be obtained from a post’s meta, meta attribute sources are considered deprecated; EntityProvider and related hook APIs should be used instead, as shown in the Create Meta Block how-to here:\n\nhttps://developer.wordpress.org/block-editor/how-to-guides/metabox/meta-block-3-add/"
"description": "Although attributes may be obtained from a post’s meta, meta attribute sources are considered deprecated; EntityProvider and related hook APIs should be used instead, as shown in the Create Meta Block how-to here:\n\nhttps://developer.wordpress.org/block-editor/how-to-guides/metabox/#step-2-add-meta-block"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In #37621, the meta box-related pages were combined into a single page, so the page does not appear to exist.

"description": "Block styles can be used to provide alternative styles to block. It works by adding a class name to the block’s wrapper. Using CSS, a theme developer can target the class name for the block style if it is selected.\n\nPlugins and Themes can also register custom block style for existing blocks.\n\nhttps://developer.wordpress.org/block-editor/reference-guides/filters/block-filters/#block-styles",
"description": "Block styles can be used to provide alternative styles to block. It works by adding a class name to the block’s wrapper. Using CSS, a theme developer can target the class name for the block style if it is selected.\n\nPlugins and Themes can also register custom block style for existing blocks.\n\nhttps://developer.wordpress.org/block-editor/reference-guides/block-api/block-styles",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Block style page were moved to the Block API directory in #31055.

@t-hamano t-hamano self-assigned this Dec 21, 2022
@t-hamano t-hamano added [Feature] Block API API that allows to express the block paradigm. [Type] Developer Documentation Documentation for developers labels Dec 21, 2022
@t-hamano t-hamano marked this pull request as ready for review December 21, 2022 02:15
@t-hamano t-hamano requested a review from ajlende as a code owner December 21, 2022 02:15
Copy link
Contributor

@ajlende ajlende left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! 👍

@ajlende ajlende merged commit 756f382 into trunk Dec 21, 2022
@ajlende ajlende deleted the fix/missing-ling-block-json branch December 21, 2022 14:47
@github-actions github-actions bot added this to the Gutenberg 14.9 milestone Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Block API API that allows to express the block paradigm. [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants