Use proper color for block styles control #46684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richtabor
added
Needs Design Feedback
|
Size Change: -6 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
|
Thanks for the PR! The background color for the toggled state seems like an oversight and a good change. However I would not change the stroke color of the inactive style as it's meant to share DNA with Items in the ItemGroup: (In fact if anything, it should use the 200 gray). The button itself has its presence noted similar to the tertiary button style, through context and the label itself. |
This reverts commit d11ae3a.
Good point. I was trying to bring it in line with the other TextControl borders. I've reverted that change. |
jasmussen
approved these changes
Dec 29, 2022
|
Flaky tests detected in b82b11f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4417354868
|
richtabor
added
[Type] Enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
I noticed that the block styles control pills do not use the proper background color ($gray-900) while doing some other testing today. We should use the correct color to resolve this inconsistency.
How?
$gray-800color with$gray-900, which is the interface "black" used throughout the UI.$gray-600border color that is employed throughout other controls.Testing Instructions
Screenshots or screencast
Before:
After: