Fix CORS error in the demo e2e test #46668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
added
[Type] Automated Testing
|
Size Change: 0 B Total Size: 1.32 MB ℹ️ View Unchanged
|
kevin940726
requested review from
gziolo,
ntwb,
nerrad,
ajitbohra and
ryanwelcher
as code owners
Mamaduka
approved these changes
Dec 20, 2022
There was a problem hiding this comment.
Thank you, @kevin940726! The failing test doesn't look to be related, so let's give this method a try.
I'll continue working on a more general solution for the CORS error and demo page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The demo e2e test has been quite flaky (#44553). This PR hopefully temporarily fixes it.
How?
--disable-web-securitydisables CORS warning.Testing Instructions
CI should pass without flaky results.