Restore gutenberg_ prefix to function calls in PHPUnit tests
#46662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielbachhuber
added
the
[Type] Bug
danielbachhuber
added
the
[Type] Build Tooling
desrosj
approved these changes
Dec 19, 2022
|
Also, looks like the performance tests only failed because of a timeout issue. Restarted just to double check the results. |
danielbachhuber
force-pushed
the
fix/navigation-link-block-test-prefix
branch
from
fd3abda to
5370890
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered in #46435
See some conversation in Slack https://wordpress.slack.com/archives/C02QB2JS7/p1671470350718839
What?
Restores the
gutenberg_prefix to function calls in the Navigation Link PHPUnit tests.Why?
The prefixes were erroneously removed in #40657. Without the prefix, the tests run against the WordPress core version of the functions, instead of the version in Gutenberg the plugin.
Testing Instructions
All tests should pass.