Data: Fix no-node-access violation in suspense tests
#46657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Code Quality
tyxla
requested review from
Mamaduka,
jsnajdr,
flootr,
chad1008,
ntsekouras and
brookewp
tyxla
added
the
[Priority] Low
|
Size Change: 0 B Total Size: 1.32 MB ℹ️ View Unchanged
|
jsnajdr
approved these changes
Dec 19, 2022
tyxla
force-pushed
the
fix/suspense-tests-no-node-access
branch
from
1157802 to
f409a1c
Compare
Yes 😅 A false positive. I think it was fixed in the newer versions of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR fixes a
no-node-accessviolation in the suspense tests.Why?
This is a preparatory PR in order tobe able to enable the
no-node-accessESLint rule for all tests.How?
We're just changing the way we access the
childrenprop to avoid the false positive.Testing Instructions
Verify tests still pass:
npm run test:unit packages/data/src/components/use-select/test/suspense.js